[AST][NFC] Silence GCC warning about broken strict aliasing rules
authorThomas Preud'homme <thomasp@graphcore.ai>
Mon, 30 Nov 2020 17:02:12 +0000 (17:02 +0000)
committerThomas Preud'homme <thomasp@graphcore.ai>
Fri, 4 Dec 2020 14:34:51 +0000 (14:34 +0000)
commit507bbc45bba90fab3f1a2b42e94ae4fbebdd6498
tree25d2742efc09ba3fa7e7e9f7c966d9da58549991
parentc4a22224d97120df55f5d1d753e7f839fdb1da2f
[AST][NFC] Silence GCC warning about broken strict aliasing rules

The deserialize() method would trigger the following warning on GCC <7:

   warning: dereferencing type-punned pointer will break
       strict-aliasing rules [-Wstrict-aliasing]

       ParamIdx P(*reinterpret_cast<ParamIdx *>(&S));
                                                  ^

&S was previously reinterpret_casted from a ParamIdx into a SerialType,
it is therefore safe to cast back into a ParamIdx. Similar to what was
done in D50608, we replace it with two static_cast via void * which
silences the warning and presumably makes GCC understand that no
strict-aliasing violation is happening.

No functional change intended.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D92384
clang/include/clang/AST/Attr.h