gpio: rcar: Check for irq_set_irq_wake() failures
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 21 May 2015 11:21:37 +0000 (13:21 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 1 Jun 2015 13:10:09 +0000 (15:10 +0200)
commit501ef0f95a57e7c32138733c468394a52244c85b
tree32ab95f1c8925d9a4fc0522359a73f6364ef5ed5
parent3fff99bc4e926d9602a7d6e8c008a0175a099ce4
gpio: rcar: Check for irq_set_irq_wake() failures

If an interrupt controller doesn't support wake-up configuration,
irq_set_irq_wake() returns an error code.  Then any subsequent call
trying to deconfigure wake-up will cause an imbalance, and a warning
will be printed:

    WARNING: CPU: 1 PID: 1341 at kernel/irq/manage.c:540 irq_set_irq_wake+0x9c/0xf8()
    Unbalanced IRQ 26 wake disable

To fix this, refrain from any further parent interrupt controller
(de)configuration if irq_set_irq_wake() failed.

Alternative fixes would be:
  - calling "gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE)" from the
    platform code,
  - setting "gic_chip.flags = IRQCHIP_SKIP_SET_WAKE" in the GIC driver
    code,
but these were withheld as the GIC hardware doesn't really support
wake-up interrupts.

Fixes: ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable when wake-up is enabled")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-rcar.c