virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit
authorRolf Neugebauer <rolf.neugebauer@docker.com>
Tue, 17 Jan 2017 18:13:51 +0000 (18:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Jan 2017 19:07:31 +0000 (14:07 -0500)
commit501db511397fd6efff3aa5b4e8de415b55559550
treeec4adab4ac22b7c21bb85dd6c3f2a54b8361ce1c
parent4b19a9e20bf99d62e1c47554f8eb2d9f520642ba
virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a
subtle change in how the virtio_net flags are derived from the SKBs
ip_summed field.

With the above commits, the flags are set to VIRTIO_NET_HDR_F_DATA_VALID
when ip_summed == CHECKSUM_UNNECESSARY, thus treating it differently to
ip_summed == CHECKSUM_NONE, which should be the same.

Further, the virtio spec 1.0 / CS04 explicitly says that
VIRTIO_NET_HDR_F_DATA_VALID must not be set by the driver.

Fixes: fd2a0437dc33 ("virtio_net: introduce virtio_net_hdr_{from,to}_skb")
Fixes: e858fae2b0b8 (" virtio_net: use common code for virtio_net_hdr and skb GSO conversion")
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/virtio_net.h