Revert "HID: logitech-hidpp: support combo keyboard touchpad TK820"
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 6 May 2015 19:01:31 +0000 (15:01 -0400)
committerJiri Kosina <jkosina@suse.cz>
Thu, 7 May 2015 08:50:51 +0000 (10:50 +0200)
commit5006c1052aafa01dab5b0e643b7dac755b41f3bb
treed68b5d23073415c1c07a84028e498e6499a5caae
parenta7d2bf25a4837e6514a2747380fd4539b63ee20c
Revert "HID: logitech-hidpp: support combo keyboard touchpad TK820"

This reverts commit 3a61e97563d78a2ca10752902449570d8433ce76.

The Logitech TK820 seems to be affected by a firmware bug which
delays the sending of the keys (pressed, or released, which triggers
a key-repeat) while holding fingers on the touch sensor.
This behavior can be observed while using the mouse emulation mode
if the user moves the finger while typing (highly improbable though).
Holding the finger still while in the mouse emulation mode does
not trigger the key repeat problem.
So better keep things in their previous state to not have to
explain users that the new key-repeat bug they see is a "feature".

Furthermore, I noticed that I disabled the media keys whith
this patch. Sorry, my bad.

I think it is best to revert the patch, in all the current
versions it has been shipped.

Cc: <stable@vger.kernel.org> # v3.19 and above
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c