drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem
authorJoe Moriarty <joe.moriarty@oracle.com>
Tue, 20 Feb 2018 19:11:56 +0000 (14:11 -0500)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 6 Mar 2018 07:14:16 +0000 (08:14 +0100)
commit4ffb8deeed58b75dd1a23580845233b6ce0dca6c
tree71cd0f060ae9f5643426fe5b17da5f360df53583
parent81af63a4af82e739aaa391d1fbb97e02c58ea6a1
drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

The Parfait (version 2.1.0) static code analysis tool found the
following NULL pointer derefernce problem.

- drivers/gpu/drm/drm_vblank.c
Null pointer checks were added to return values from calls to
drm_crtc_from_index().  There is a possibility, however minute, that
crtc->index may not be found when trying to find the struct crtc
from it's assigned index given in drm_crtc_init_with_planes().
3 return checks for NULL where added with a call to
WARN_ON(!crtc).

Signed-off-by: Joe Moriarty <joe.moriarty@oracle.com>
Reviewed-by: Steven Sistare <steven.sistare@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180220191157.100960-2-joe.moriarty@oracle.com
drivers/gpu/drm/drm_vblank.c