net: bnx2x: fix variable dereferenced before check
authorPavel Skripkin <paskripkin@gmail.com>
Sat, 13 Nov 2021 22:36:36 +0000 (01:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 09:39:14 +0000 (10:39 +0100)
commit4fc060abaa2674f154e708aaafc0d3c780d0a418
tree857ef8fe086a87f0f96ca8eafaaff7c49cf5e4d9
parent3ae75cc38a8457df4d3e1667dded7d51b08a5af8
net: bnx2x: fix variable dereferenced before check

[ Upstream commit f8885ac89ce310570e5391fe0bf0ec9c7c9b4fdc ]

Smatch says:
bnx2x_init_ops.h:640 bnx2x_ilt_client_mem_op()
warn: variable dereferenced before check 'ilt' (see line 638)

Move ilt_cli variable initialization _after_ ilt validation, because
it's unsafe to deref the pointer before validation check.

Fixes: 523224a3b3cd ("bnx2x, cnic, bnx2i: use new FW/HSI")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h