selftests/bpf: make test_align selftest more robust
authorAndrii Nakryiko <andrii@kernel.org>
Fri, 4 Nov 2022 16:36:49 +0000 (09:36 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 4 Nov 2022 18:51:45 +0000 (11:51 -0700)
commit4f999b767769b76378c3616c624afd6f4bb0d99f
treea392af5680bb1b3435accd9fb49bd16304cee0fa
parent7a830b53c17bbadcf99f778f28aaaa4e6c41df5f
selftests/bpf: make test_align selftest more robust

test_align selftest relies on BPF verifier log emitting register states
for specific instructions in expected format. Unfortunately, BPF
verifier precision backtracking log interferes with such expectations.
And instruction on which precision propagation happens sometimes don't
output full expected register states. This does indeed look like
something to be improved in BPF verifier, but is beyond the scope of
this patch set.

So to make test_align a bit more robust, inject few dummy R4 = R5
instructions which capture desired state of R5 and won't have precision
tracking logs on them. This fixes tests until we can improve BPF
verifier output in the presence of precision tracking.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20221104163649.121784-7-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/prog_tests/align.c