lib/xz: Validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Sun, 10 Oct 2021 21:31:40 +0000 (05:31 +0800)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Tue, 19 Oct 2021 15:44:30 +0000 (23:44 +0800)
commit4f8d7abaa413c34da9d751289849dbfb7c977d05
treec6d22bb98c2785fd33a291fd01b75b1dc1b71f3e
parent83d3c4f22a36d005b55f44628f46cc0d319a75e8
lib/xz: Validate the value before assigning it to an enum variable

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
lib/xz/xz_dec_stream.c