ALSA: hda: intel: More comprehensive PM runtime setup for controller driver
authorTakashi Iwai <tiwai@suse.de>
Mon, 15 Nov 2021 07:59:44 +0000 (08:59 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 15 Nov 2021 09:22:15 +0000 (10:22 +0100)
commit4f66a9ef37d3c09917a1edc065ff68b895e0b163
treee54454a2ef067df3865b7e1e3778157575e156f9
parentfa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
ALSA: hda: intel: More comprehensive PM runtime setup for controller driver

Currently we haven't explicitly enable and allow/forbid the runtime PM
at the probe and the remove phases of HD-audio controller driver, and
this was the reason of a GPF mentioned in the commit e81478bbe7a1
("ALSA: hda: fix general protection fault in azx_runtime_idle");
namely, even after the resources are released, the runtime PM might be
still invoked by the bound graphics driver during the remove of the
controller driver.  Although we've fixed it by clearing the drvdata
reference, it'd be also better to cover the runtime PM issue more
properly.

This patch adds a few more pm_runtime_*() calls at the probe and the
remove time for setting and cleaning up the runtime PM.  Particularly,
now more explicitly pm_runtime_enable() and _disable() get called as
well as pm_runtime_forbid() call at the remove callback, so that a
use-after-free should be avoided.

Reported-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Tested-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20211110210307.1172004-1-kai.vehmanen@linux.intel.com
Link: https://lore.kernel.org/r/20211115075944.6972-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c