ccconverter: fix missing output framerate on the caps
authorMatthew Waters <matthew@centricular.com>
Wed, 1 Jul 2020 09:41:33 +0000 (19:41 +1000)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 1 Jul 2020 19:33:56 +0000 (19:33 +0000)
commit4f334234c82cc8924eab4b8bdd7fc7593c97dc85
tree22f22522eeab5417207269e75339bca240703994
parent1e29c5d52ae0eb71222ddc85529d8beb696855e9
ccconverter: fix missing output framerate on the caps

A pipeline like this:

closedcaption/x-cea-708,format=cdp,framerate=30000/1001 ! ccconverter ! closedcaption/x-cea-708,format=cc_data

would produce a critical/assert:

GStreamer-CRITICAL **: 14:21:11.509: gst_util_fraction_multiply: assertion 'a_d != 0' failed

because there would be no framerate field on ccconverter's output.

Fixed by always fixating a framerate if the input has a framerate.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1393>
ext/closedcaption/gstccconverter.c
tests/check/elements/ccconverter.c