sata_sil24: always set protocol override for non-ATAPI data commands
authorRobert Hancock <hancockrwd@gmail.com>
Thu, 30 Jul 2009 20:11:29 +0000 (14:11 -0600)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 1 Sep 2009 23:47:21 +0000 (19:47 -0400)
commit4f1a0ee11d6f9c104c8e6a13dae995709a6922a8
tree5402b32fb0ba17c3d9f44c21faddbefd73d2812f
parent77cdec1ad527560b59ab8dbb063dbb3d0a138bf7
sata_sil24: always set protocol override for non-ATAPI data commands

The sil24 hardware has a built-in list of commands and associated protocols
that gets used by default to decide how to handle a given command. However,
if the command is not known to the controller then it presumably assumes it to
be a non-data command which then causes protocol mismatch errors if the device
ends up requesting data transfer. The new DATA SET MANAGEMENT - Trim command
causes this issue since it's a DMA data-out command.

Since we should always know best what protocol the command should be using,
let's just set the override flag to inform the controller what protocol to use
for all non-ATAPI commands with data transfer.

Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
Tested-by: Mark Lord <liml@rtr.ca>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_sil24.c