projects / profile / common / kernel-common.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8d567b6) | patch
ASoC: Move dereference after NULL test
authorJulia Lawall <julia@diku.dk>
Sat, 17 Oct 2009 06:32:56 +0000 (08:32 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 19 Oct 2009 15:12:35 +0000 (16:12 +0100)
commit4f066173fe8deb8874f41917e5d26ea2e0c46e3b
tree95bffc1d1120c0fb65b932416f6c95ac319c3589tree | snapshot
parent8d567b6b441bfcc20e8cbebc0dc376b2e280cd88commit | diff
ASoC: Move dereference after NULL test

If the NULL test on jack is needed, then the derefernce should be after the
NULL test.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/soc-jack.c diff | blob | history
Domain: SCM / Uncategorized;