ARM: trusted_foundations: do not use naked function
authorStefan Agner <stefan@agner.ch>
Sun, 25 Mar 2018 18:09:56 +0000 (20:09 +0200)
committerThierry Reding <treding@nvidia.com>
Wed, 11 Jul 2018 12:40:43 +0000 (14:40 +0200)
commit4ea7bdc6b5b33427bbd3f41c333e21c1825462a3
tree462899170e53bb759833d7dee5547b374255890d
parentce397d215ccd07b8ae3f71db689aedb85d56ab40
ARM: trusted_foundations: do not use naked function

As documented in GCC naked functions should only use basic ASM
syntax. The extended ASM or mixture of basic ASM and "C" code is
not guaranteed. Currently this works because it was hard coded
to follow and check GCC behavior for arguments and register
placement.

Furthermore with clang using parameters in Extended asm in a
naked function is not supported:
  arch/arm/firmware/trusted_foundations.c:47:10: error: parameter
          references not allowed in naked functions
                : "r" (type), "r" (arg1), "r" (arg2)
                       ^

Use a regular function to be more portable. This aligns also with
the other SMC call implementations e.g. in qcom_scm-32.c and
bcm_kona_smc.c.

Cc: Dmitry Osipenko <digetx@gmail.com>
Cc: Stephen Warren <swarren@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>
Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Thierry Reding <treding@nvidia.com>
arch/arm/firmware/trusted_foundations.c