Btrfs: return immediately if tree log mod is not necessary
authorFilipe David Borba Manana <fdmanana@gmail.com>
Thu, 12 Dec 2013 19:19:52 +0000 (19:19 +0000)
committerJiri Slaby <jslaby@suse.cz>
Sat, 1 Mar 2014 19:44:33 +0000 (20:44 +0100)
commit4e6e3bd45f6fd9caac44f6fa944a78d81f2d8d1d
tree419c85d63d39d6c74b5070e8407210818f3e9890
parent2b183ff24e726b97e2eeef5a54f88d4a8ac4f7d8
Btrfs: return immediately if tree log mod is not necessary

commit 783577663507411e36e459390ef056556e93ef29 upstream.

In ctree.c:tree_mod_log_set_node_key() we were calling
__tree_mod_log_insert_key() even when the modification doesn't need
to be logged. This would allocate a tree_mod_elem structure, fill it
and pass it to  __tree_mod_log_insert(), which would just acquire
the tree mod log write lock and then free the tree_mod_elem structure
and return (that is, a no-op).

Therefore call tree_mod_log_insert() instead of __tree_mod_log_insert()
which just returns immediately if the modification doesn't need to be
logged (without allocating the structure, fill it, acquire write lock,
free structure).

Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/btrfs/ctree.c