[asan] Restore ODR-violation detection on vtables
authorVitaly Buka <vitalybuka@google.com>
Tue, 18 Dec 2018 22:23:30 +0000 (22:23 +0000)
committerVitaly Buka <vitalybuka@google.com>
Tue, 18 Dec 2018 22:23:30 +0000 (22:23 +0000)
commit4e4920694cae642b6eea869d1f7475c61741ec44
tree573c97577cb4472a1f106d663f0f5f77096f2990
parent608d128c4224ddadb63341750633253795163370
[asan] Restore ODR-violation detection on vtables

Summary:
unnamed_addr is still useful for detecting of ODR violations on vtables

Still unnamed_addr with lld and --icf=safe or --icf=all can trigger false
reports which can be avoided with --icf=none or by using private aliases
with -fsanitize-address-use-odr-indicator

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: kubamracek, hiraditya, llvm-commits

Differential Revision: https://reviews.llvm.org/D55799

llvm-svn: 349555
compiler-rt/test/asan/TestCases/Linux/odr-vtable.cc [new file with mode: 0644]
llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
llvm/test/Instrumentation/AddressSanitizer/odr-check-ignore.ll