[media] cx88: Fix regression in initial video standard setting
authorDevin Heitmueller <dheitmueller@kernellabs.com>
Sat, 20 Sep 2014 12:23:44 +0000 (09:23 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 10:26:25 +0000 (07:26 -0300)
commit4e0973a918b9a42e217093f078e04a61e5dd95a5
tree41ef9ad76811900a8e0119a45251fa7db611ebcb
parent37404f91ef8b910e6117b7920c082d71aba27250
[media] cx88: Fix regression in initial video standard setting

Setting initial standard at the top of cx8800_initdev would cause the
first call to cx88_set_tvnorm() to return without programming any
registers (leaving the driver saying it's set to NTSC but the hardware
isn't programmed).  Even worse, any subsequent attempt to explicitly
set it to NTSC-M will return success but actually fail to program the
underlying registers unless first changing the standard to something
other than NTSC-M.

Set the initial standard later in the process, and make sure the field
is zero at the beginning to ensure that the call always goes through.

This regression was introduced in the following commit:

commit ccd6f1d488e7 ("[media] cx88: move width, height and field to core
struct")

Author: Hans Verkuil <hans.verkuil@cisco.com>

[media] cx88: move width, height and field to core struct

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: <stable@vger.kernel.org> # for v3.19 and up
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/cx88/cx88-cards.c
drivers/media/pci/cx88/cx88-video.c