perf/x86/intel/lbr: Zero the xstate buffer on allocation
authorThomas Gleixner <tglx@linutronix.de>
Fri, 11 Jun 2021 13:03:16 +0000 (15:03 +0200)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:47:18 +0000 (08:47 -0400)
commit4df9ed0edb9f6f60afcf1fd70640cebc7eceb3c7
treeb7a8085a229320ca2adf06fd0df74c29a3e6b728
parent56bc20e5fc64d55c194475692ee60893a3f452a5
perf/x86/intel/lbr: Zero the xstate buffer on allocation

[ Upstream commit 7f049fbdd57f6ea71dc741d903c19c73b2f70950 ]

XRSTORS requires a valid xstate buffer to work correctly. XSAVES does not
guarantee to write a fully valid buffer according to the SDM:

  "XSAVES does not write to any parts of the XSAVE header other than the
   XSTATE_BV and XCOMP_BV fields."

XRSTORS triggers a #GP:

  "If bytes 63:16 of the XSAVE header are not all zero."

It's dubious at best how this can work at all when the buffer is not zeroed
before use.

Allocate the buffers with __GFP_ZERO to prevent XRSTORS failure.

Fixes: ce711ea3cab9 ("perf/x86/intel/lbr: Support XSAVES/XRSTORS for LBR context switch")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/87wnr0wo2z.ffs@nanos.tec.linutronix.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/events/intel/lbr.c