drm/vkms: remove the need for the primary plane to be visible
authorMaíra Canal <mcanal@igalia.com>
Fri, 24 Mar 2023 16:42:25 +0000 (13:42 -0300)
committerMaíra Canal <mairacanal@riseup.net>
Thu, 6 Apr 2023 12:05:46 +0000 (09:05 -0300)
commit4dee3c4b32a65d6b140ed506a7a8859d5cab6611
treef7717481c7a9ce32975c174a6ecb92a9c53e8dbc
parente44f18c6ff8beef7b2b10592287f0a9766376d9b
drm/vkms: remove the need for the primary plane to be visible

Before commit bc0d7fdefec6 ("drm: vkms: Supports to the case where
primary plane doesn't match the CRTC"), the composition was executed on
top of the primary plane. Therefore, the primary plane needed to be
visible and full screen. After commit bc0d7fdefec6, this is no longer
necessary, as the composition is now executed on top of the CRTC.

Then, remove the conditional expression that forced the primary plane to
be visible and full screen. This allows vkms to accept non-null
framebuffers when the CRTC is disabled.

This patch was tested with the vkms IGT testlist and all tests passed
successfully. Moreover, the tests
igt@kms_universal_plane@universal-plane-pipe-a-functional and
igt@kms_universal_plane@disable-primary-vs-flip-pipe-a used to fail and
now are passing.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Maíra Canal <mairacanal@riseup.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230324164226.256084-2-mcanal@igalia.com
drivers/gpu/drm/vkms/vkms_plane.c