netlabel: Less function calls in netlbl_mgmt_add_common() after error detection
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 2 Feb 2015 10:00:24 +0000 (11:00 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Feb 2015 00:22:13 +0000 (16:22 -0800)
commit4de46d5ebc000ea110bcb76a7478c1ac37724221
treeeaf93ec8c6483184656e83b98d5a78eda53d3e6b
parent7a11b1d303ee97e4880caa3efc2f5cecc28d4ba2
netlabel: Less function calls in netlbl_mgmt_add_common() after error detection

The functions "cipso_v4_doi_putdef" and "kfree" could be called in some cases
by the netlbl_mgmt_add_common() function during error handling even if the
passed variables contained still a null pointer.

* This implementation detail could be improved by adjustments for jump labels.

* Let us return immediately after the first failed function call according to
  the current Linux coding style convention.

* Let us delete also an unnecessary check for the variable "entry" there.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlabel/netlabel_mgmt.c