Kbuild: use -Wdeclaration-after-statement
authorMark Rutland <mark.rutland@arm.com>
Tue, 8 Mar 2022 21:56:13 +0000 (22:56 +0100)
committerMasahiro Yamada <masahiroy@kernel.org>
Sun, 13 Mar 2022 08:31:10 +0000 (17:31 +0900)
commit4d94f910e79a349b00a4f8aab6f3ae87129d8c5a
treee00333da4ecd8fd0b60f5798517e9fd6a95c03c5
parent1344794a59db2bd44b4919d2d75300fd3b1c2cd7
Kbuild: use -Wdeclaration-after-statement

The kernel is moving from using `-std=gnu89` to `-std=gnu11`, permitting
the use of additional C11 features such as for-loop initial declarations.

One contentious aspect of C99 is that it permits mixed declarations and
code, and for now at least, it seems preferable to enforce that
declarations must come first.

These warnings were already enabled in the kernel itself, but not
for KBUILD_USERCFLAGS or the compat VDSO on arch/arm64, which uses
a separate set of CFLAGS.

This patch fixes an existing violation in modpost.c, which is not
reported because of the missing flag in KBUILD_USERCFLAGS:

| scripts/mod/modpost.c: In function ‘match’:
| scripts/mod/modpost.c:837:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
|   837 |   const char *endp = p + strlen(p) - 1;
|       |   ^~~~~

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[arnd: don't add a duplicate flag to the default set, update changelog]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM/Clang v13.0.0 (x86-64)
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Makefile
arch/arm64/kernel/vdso32/Makefile
scripts/mod/modpost.c