drm: bridge/panel: Cleanup connector on bridge detach
authorPaul Cercueil <paul@crapouillou.net>
Sat, 27 Mar 2021 11:57:40 +0000 (11:57 +0000)
committerPaul Cercueil <paul@crapouillou.net>
Mon, 29 Mar 2021 15:46:01 +0000 (16:46 +0100)
commit4d906839d321c2efbf3fed4bc31ffd9ff55b75c0
tree0d741daecaf73242a356331510d39475fbdd871b
parent680dcede2762668e7fd9a8d4280453b7f260b680
drm: bridge/panel: Cleanup connector on bridge detach

If we don't call drm_connector_cleanup() manually in
panel_bridge_detach(), the connector will be cleaned up with the other
DRM objects in the call to drm_mode_config_cleanup(). However, since our
drm_connector is devm-allocated, by the time drm_mode_config_cleanup()
will be called, our connector will be long gone. Therefore, the
connector must be cleaned up when the bridge is detached to avoid
use-after-free conditions.

v2: Cleanup connector only if it was created

v3: Add FIXME

v4: (Use connector->dev) directly in if() block

Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.")
Cc: <stable@vger.kernel.org> # 4.12+
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210327115742.18986-2-paul@crapouillou.net
drivers/gpu/drm/bridge/panel.c