review.tizen.org Git - platform/upstream/dotnet/runtime.git/commit

projects / platform / upstream / dotnet / runtime.git / commit

author	David Cantu <dacantu@microsoft.com>
	Tue, 7 Jul 2020 02:10:17 +0000 (19:10 -0700)
committer	GitHub <noreply@github.com>
	Tue, 7 Jul 2020 02:10:17 +0000 (19:10 -0700)
commit	4d579de12b3002e460fb33611f5f95ff6c30170d
tree	f38627b9fee3e6d232f8c8edacf0a5c176ed52f8	tree \| snapshot
parent	67646332c079f2544ad9b05b361a5569c913c809	commit \| diff

Add support for multiple non-string TKey on dictionaries (#38056)

* Add support for multiple non-string TKey on dictionaries

* Fix build errors

* Fix performance regression

* Add Read/WriteWithQuotes to the remaining supported types

* Add support for a few more missing types

* Add policy support for Enum keys

* Address performance regression.

* Fix test error on netstandard

* 1. Add support for escaped characters on Read and avoid escaping on Write
2. Address some feedback

* Remove TryGet*Core methods to mitigate perf regression

* Remove duplicated escaping tests

* Cache TKey and TValue converters

* Remove duplicated code used to read the dictionary key

* Bring back TryGet*Core

* Fix test errors with floating point types

* Address nits and feedback from steveharter

55 files changed:

src/libraries/System.Text.Json/src/Resources/Strings.resx		diff \| blob \| history
src/libraries/System.Text.Json/src/System.Text.Json.csproj		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/JsonConstants.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/DictionaryDefaultConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/DictionaryOfTKeyTValueConverter.cs	[moved from src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/DictionaryOfStringTValueConverter.cs with 66% similarity]	diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IDictionaryConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IDictionaryOfTKeyTValueConverter.cs	[moved from src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IDictionaryOfStringTValueConverter.cs with 76% similarity]	diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IEnumerableConverterFactory.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IReadOnlyDictionaryOfTKeyTValueConverter.cs	[moved from src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IReadOnlyDictionaryOfStringTValueConverter.cs with 65% similarity]	diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/ImmutableDictionaryOfTKeyTValueConverter.cs	[moved from src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/ImmutableDictionaryOfStringTValueConverter.cs with 70% similarity]	diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/BooleanConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/CharConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateTimeConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateTimeOffsetConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DecimalConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DoubleConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/GuidConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/Int16Converter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/Int32Converter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/Int64Converter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ObjectConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/SByteConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/SingleConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/StringConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/UInt16Converter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/UInt32Converter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/UInt64Converter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadStackFrame.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.DateTime.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.DateTimeOffset.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.Decimal.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.Double.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.Float.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.Guid.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.Literal.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.SignedNumber.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.String.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.UnsignedNumber.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.Dictionary.NonStringKey.cs	[new file with mode: 0644]	blob
src/libraries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.Dictionary.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.Generic.Read.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/CustomConverterTests/CustomConverterTests.DerivedTypes.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/ExtensionDataTests.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/Serialization/PropertyVisibilityTests.cs		diff \| blob \| history
src/libraries/System.Text.Json/tests/System.Text.Json.Tests.csproj		diff \| blob \| history

Domain: Dotnet / Core;

RSS Atom