net/sched: flower: fix possible OOB write in fl_set_geneve_opt()
authorHangyu Hua <hbh25y@gmail.com>
Wed, 31 May 2023 10:28:04 +0000 (18:28 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 1 Jun 2023 10:59:04 +0000 (12:59 +0200)
commit4d56304e5827c8cc8cc18c75343d283af7c4825c
tree0e37936f1efc7237ca0b9d3ebce6f1d360bb98d5
parent622ab656344a288acf4fb03d628c3bb5dd241f34
net/sched: flower: fix possible OOB write in fl_set_geneve_opt()

If we send two TCA_FLOWER_KEY_ENC_OPTS_GENEVE packets and their total
size is 252 bytes(key->enc_opts.len = 252) then
key->enc_opts.len = opt->length = data_len / 4 = 0 when the third
TCA_FLOWER_KEY_ENC_OPTS_GENEVE packet enters fl_set_geneve_opt. This
bypasses the next bounds check and results in an out-of-bounds.

Fixes: 0a6e77784f49 ("net/sched: allow flower to match tunnel options")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Link: https://lore.kernel.org/r/20230531102805.27090-1-hbh25y@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/cls_flower.c