netlink: Don't shift with UB on nlk->ngroups
authorDmitry Safonov <dima@arista.com>
Mon, 30 Jul 2018 17:32:36 +0000 (18:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Aug 2018 10:17:59 +0000 (12:17 +0200)
commit4d502572ea7da97550891c2b0bcd36fa4eb33401
tree31828bd913f8681c88a0485b9b04a013227958a6
parent4f08437d6cc3c243c868207a474496fb253c10ff
netlink: Don't shift with UB on nlk->ngroups

[ Upstream commit 61f4b23769f0cc72ae62c9a81cf08f0397d40da8 ]

On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting in
hang during boot.
Check for 0 ngroups and use (unsigned long long) as a type to shift.

Fixes: 7acf9d4237c4 ("netlink: Do not subscribe to non-existent groups").
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netlink/af_netlink.c