ext4: fix error handling on inode bitmap corruption
authorJan Kara <jack@suse.cz>
Sun, 18 Dec 2011 22:37:02 +0000 (17:37 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:43:52 +0000 (00:43 +0100)
commit4d44d39c1a2ac1fe747f1808220ee09369edc313
tree0b989de4ed06e7f53bf7a570ddc56427a945a0cf
parentb5451060a038e1d725d22ca8e852704903167514
ext4: fix error handling on inode bitmap corruption

commit acd6ad83517639e8f09a8c5525b1dccd81cd2a10 upstream.

When insert_inode_locked() fails in ext4_new_inode() it most likely means inode
bitmap got corrupted and we allocated again inode which is already in use. Also
doing unlock_new_inode() during error recovery is wrong since the inode does
not have I_NEW set. Fix the problem by jumping to fail: (instead of fail_drop:)
which declares filesystem error and does not call unlock_new_inode().

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/ialloc.c