selinux: drop unnecessary NULL check
authorChristian Göttsche <cgzones@googlemail.com>
Thu, 17 Feb 2022 14:21:28 +0000 (15:21 +0100)
committerPaul Moore <paul@paul-moore.com>
Tue, 7 Jun 2022 21:20:10 +0000 (17:20 -0400)
commit4d3d0ed60ee0d2da4c541e525c132dc374464624
tree421ef603a1a83df177f2e62b059b49ef1079f2ab
parent494688efdc5912b858d0a05563c9cf258c75d29a
selinux: drop unnecessary NULL check

Commit e3489f8974e1 ("selinux: kill selinux_sb_get_mnt_opts()")
introduced a NULL check on the context after a successful call to
security_sid_to_context().  This is on the one hand redundant after
checking for success and on the other hand insufficient on an actual
NULL pointer, since the context is passed to seq_escape() leading to a
call of strlen() on it.

Reported by Clang analyzer:

    In file included from security/selinux/hooks.c:28:
    In file included from ./include/linux/tracehook.h:50:
    In file included from ./include/linux/memcontrol.h:13:
    In file included from ./include/linux/cgroup.h:18:
    ./include/linux/seq_file.h:136:25: warning: Null pointer passed as 1st argument to string length function [unix.cstring.NullArg]
            seq_escape_mem(m, src, strlen(src), flags, esc);
                                   ^~~~~~~~~~~

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/hooks.c