Move RegistryKey to shared CoreLib partition (#20067)
authorJan Kotas <jkotas@microsoft.com>
Thu, 20 Sep 2018 21:14:48 +0000 (14:14 -0700)
committerGitHub <noreply@github.com>
Thu, 20 Sep 2018 21:14:48 +0000 (14:14 -0700)
commit4ca5cd260a1c04f74961faccfad3200fe865a249
tree539038626f286075d6942d3ca75a7d887c2b2456
parent0f4ecd9ccc1c7bad32d7ec8eb8bb335f67cfd432
Move RegistryKey to shared CoreLib partition (#20067)

* Move RegistryKey to shared CoreLib partition

- Cut down RegistryKey to just what CoreLib needs. I went back and forth on whether to share the corefx implementation with ifdefs or not. I have choosen to duplicate it at the end. The ifdefs were either too complex or there was too much cruft left behind that the IL linker was not able to remove.
- Move the internal CoreLib implementation of Registry to Internal.Win32 namespace to ensure that it is not confused with the public standlone one

Fixes #10741 and #17899
29 files changed:
src/System.Private.CoreLib/Resources/Strings.resx
src/System.Private.CoreLib/System.Private.CoreLib.csproj
src/System.Private.CoreLib/shared/Internal/Win32/RegistryKey.cs [new file with mode: 0644]
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegCreateKeyEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegDeleteKeyEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegDeleteValue.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegEnumKeyEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegEnumValue.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegFlushKey.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegOpenKeyEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegQueryInfoKey.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegQueryValueEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.RegSetValueEx.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/Registry.cs [deleted file]
src/System.Private.CoreLib/shared/Microsoft/Win32/RegistryHive.cs [deleted file]
src/System.Private.CoreLib/shared/Microsoft/Win32/RegistryOptions.cs [deleted file]
src/System.Private.CoreLib/shared/Microsoft/Win32/RegistryValueKind.cs [deleted file]
src/System.Private.CoreLib/shared/Microsoft/Win32/RegistryValueOptions.cs [deleted file]
src/System.Private.CoreLib/shared/Microsoft/Win32/RegistryView.cs [deleted file]
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeRegistryHandle.Windows.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeRegistryHandle.cs
src/System.Private.CoreLib/shared/System.Private.CoreLib.Shared.projitems
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventProvider.cs
src/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.Win32.cs
src/System.Private.CoreLib/shared/System/Globalization/JapaneseCalendar.Win32.cs
src/System.Private.CoreLib/shared/System/Security/AccessControl/RegistryRights.cs [deleted file]
src/System.Private.CoreLib/shared/System/TimeZoneInfo.Win32.cs
src/System.Private.CoreLib/src/Microsoft/Win32/RegistryKey.cs [deleted file]
src/System.Private.CoreLib/src/System/Environment.cs