ALSA: usb-audio: caiaq: fix endianness bug in snd_usb_caiaq_maschine_dispatch
authorEldad Zack <eldad@fogrefinery.com>
Mon, 29 Apr 2013 19:15:46 +0000 (21:15 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 30 Apr 2013 07:19:02 +0000 (09:19 +0200)
commit4ca231b2e6ed171107c5b21f9e92d1965fd6fd9e
tree25acf07f6210c17b7a1f930e7d136d0202094dba
parent167d0a11d5feedd1f9cb9ae128ac543e97148eff
ALSA: usb-audio: caiaq: fix endianness bug in snd_usb_caiaq_maschine_dispatch

Current code does this:

  be16_to_cpu(buf[i * 2] << 8 | buf[(i * 2) + 1])

Which is effectively (neglecting the index):

  be16_to_cpu(be16_to_cpu(*((u16 *) buf)))

This means the int16 in the buffer is not converted at all.

Daniel Mack confirmed that the driver works on little endian
CPUs, leading to the conclusion that the device-side structure
is actually little endian.
This changes the code to use le16_to_cpu().

Caught by sparse.

Acked-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/caiaq/input.c