iommu: fix KASAN use-after-free in iommu_insert_resv_region
authorEric Auger <eric.auger@redhat.com>
Tue, 26 Nov 2019 17:54:13 +0000 (18:54 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 16 Dec 2019 16:58:42 +0000 (08:58 -0800)
commit4c80ba392bf603d468ea827d902f8e7b2505fbf4
tree1c1e5bc6a0ac7fa9d5ff86da7330d0860aaaf9af
parent7de7de7ca0ae0fc70515ee3154af33af75edae2c
iommu: fix KASAN use-after-free in iommu_insert_resv_region

In case the new region gets merged into another one, the nr list node is
freed.  Checking its type while completing the merge algorithm leads to
a use-after-free.  Use new->type instead.

Fixes: 4dbd258ff63e ("iommu: Revisit iommu_insert_resv_region() implementation")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reported-by: Qian Cai <cai@lca.pw>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Stable <stable@vger.kernel.org> #v5.3+
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/iommu/iommu.c