USB: serial: ch341: fix type promotion bug in ch341_control_in()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 4 Jul 2018 09:29:38 +0000 (12:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jul 2018 09:37:52 +0000 (11:37 +0200)
commit4c73f193b320d8463c280ef8b4df314fb291f76b
treed01948690e6f6d180925d219062ebe36e07ee48c
parentf510cc3a2f314b299b6dd7bce93a11dfe7adaabe
USB: serial: ch341: fix type promotion bug in ch341_control_in()

commit e33eab9ded328ccc14308afa51b5be7cbe78d30b upstream.

The "r" variable is an int and "bufsize" is an unsigned int so the
comparison is type promoted to unsigned.  If usb_control_msg() returns a
negative that is treated as a high positive value and the error handling
doesn't work.

Fixes: 2d5a9c72d0c4 ("USB: serial: ch341: fix control-message error handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/ch341.c