staging: comedi: usbdux: consolidate the firmware upload
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 20 May 2013 21:29:39 +0000 (14:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 May 2013 17:59:11 +0000 (10:59 -0700)
commit4bf6bfe3c8ae4d41c2bb3784981ba069c80ef55e
tree892ff446125e7db385c46b3799ee5a836446fd0e
parent71f89d1813535efb0839248446c349da92cd527a
staging: comedi: usbdux: consolidate the firmware upload

Absorb the usbdux_stop(), usbdux_upload(), and usbdux_start()
functions into firmware_upload().

Each of them just do a usb_control_msg() to the device and output
an error message if it fails. A similar message is also output by
firmware_upload() so the extra messages are redundant.

We can also share the malloc'ed local buffer needed for the
usb_control_msg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbdux.c