Fix PTRACE_GETREGSET failure for compat inferiors on arm64
authorKees Cook <keescook@chromium.org>
Fri, 27 Jan 2017 11:14:47 +0000 (11:14 +0000)
committerYao Qi <yao.qi@linaro.org>
Fri, 27 Jan 2017 11:14:47 +0000 (11:14 +0000)
commit4bd2e1b2aee122b46e335d932f7833f9c86610d0
tree2c072870aa7c29b77ec26a39a752d222aab3b616
parent22d9a0dee3a69973858000b326cf8eaa14ce7180
Fix PTRACE_GETREGSET failure for compat inferiors on arm64

When running a 32-bit ARM inferior with a 32-bit ARM GDB on a 64-bit
AArch64 host, only VFP registers (NT_ARM_VFP) are available. The FPA
registers (NT_PRFPREG) are not available so GDB must not request them, as
this will fail with -EINVAL.  This is most noticeably exposed when running
"generate-core-file":

(gdb) generate-core-file myprog.core
Unable to fetch the floating point registers.: Invalid argument.

ptrace(PTRACE_GETREGSET, 27642, NT_FPREGSET, 0xffcc67f0) = -1 EINVAL (Invalid argument)

gdb/ChangeLog:

2017-01-27  Kees Cook  <keescook@google.com>

* gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call
fetch_fpregs if target has fpa registers.
(arm_linux_store_inferior_registers): Call store_fpregs if target
has fpa registers.
gdb/ChangeLog
gdb/arm-linux-nat.c