Improve optional formatter
authorWalter Erquinigo <wallace@fb.com>
Tue, 23 Nov 2021 17:16:59 +0000 (09:16 -0800)
committerWalter Erquinigo <wallace@fb.com>
Tue, 23 Nov 2021 21:52:17 +0000 (13:52 -0800)
commit4ba5da8e3d38f38ed7845c22baadd8908729c520
treebb9745eae77a13791ad0627d7851725a24b5cc40
parent892648b18a8cc3b8a08528112adfa74bdd432f8b
Improve optional formatter

As suggested by @labath in https://reviews.llvm.org/D114403, we should
make the formatter more resilient to corrupted data. The Libcxx version
explicitly checks for engaged = 1, so we can do that as well for safety.

Differential Revision: https://reviews.llvm.org/D114450
lldb/examples/synthetic/gnu_libstdcpp.py
lldb/source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/optional/TestDataFormatterGenericOptional.py