media: i2c: ds90ub960: fix error handling in ub960_rxport_add_serializer()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 18 Jul 2023 14:06:58 +0000 (07:06 -0700)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 19 Jul 2023 10:57:51 +0000 (12:57 +0200)
commit4b9fbbd58e35337d59431e988149930c1987dc30
tree83a9cfe5a40e51cdf8003b704797f7d08db2d84e
parent37048e171cda6f000b97b4b4931659254db8f63d
media: i2c: ds90ub960: fix error handling in ub960_rxport_add_serializer()

Smatch warns:
 drivers/media/i2c/ds90ub960.c:1671 ub960_rxport_add_serializer():
 err: 'rxport->ser.client' dereferencing possible ERR_PTR()

i2c_new_client_device() returns error pointers on failure and in
dev_dbg statement we are dereferencing error pointer which is a bug.

Fix this by using IS_ERR() which checks for error pointers.

Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/ds90ub960.c