tracing/histograms: Return an error if we fail to add histogram to hist_vars list
authorMohamed Khalfella <mkhalfella@purestorage.com>
Fri, 14 Jul 2023 20:33:41 +0000 (20:33 +0000)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Sun, 23 Jul 2023 15:18:52 +0000 (11:18 -0400)
commit4b8b3905165ef98386a3c06f196c85d21292d029
treeb933f374abed4c2110ea812439482240bc728703
parent8a96c0288d0737ad77882024974c075345c72011
tracing/histograms: Return an error if we fail to add histogram to hist_vars list

Commit 6018b585e8c6 ("tracing/histograms: Add histograms to hist_vars if
they have referenced variables") added a check to fail histogram creation
if save_hist_vars() failed to add histogram to hist_vars list. But the
commit failed to set ret to failed return code before jumping to
unregister histogram, fix it.

Link: https://lore.kernel.org/linux-trace-kernel/20230714203341.51396-1-mkhalfella@purestorage.com
Cc: stable@vger.kernel.org
Fixes: 6018b585e8c6 ("tracing/histograms: Add histograms to hist_vars if they have referenced variables")
Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c