openvswitch: do not ignore netdev errors when creating tunnel vports
authorMartynas Pumputis <martynas@weave.works>
Tue, 9 Aug 2016 15:24:50 +0000 (16:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Aug 2016 06:13:23 +0000 (23:13 -0700)
commit4b5b9ba553f9aa5f484ab972fc9b58061885ceca
treea49284b85664db33831c1d8a6d115a38ba045457
parentdafa6b0db2d62164c5ef81a40312d5ba514126b9
openvswitch: do not ignore netdev errors when creating tunnel vports

The creation of a tunnel vport (geneve, gre, vxlan) brings up a
corresponding netdev, a multi-step operation which can fail.

For example, changing a vxlan vport's netdev state to 'up' binds the
vport's socket to a UDP port - if the binding fails (e.g. due to the
port being in use), the error is currently ignored giving the
appearance that the tunnel vport creation completed successfully.

Signed-off-by: Martynas Pumputis <martynas@weave.works>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/vport-geneve.c
net/openvswitch/vport-gre.c
net/openvswitch/vport-vxlan.c