HID: magicmouse: fix NULL-deref on disconnect
authorJohan Hovold <johan@kernel.org>
Mon, 17 May 2021 10:04:30 +0000 (12:04 +0200)
committerJiri Kosina <jkosina@suse.cz>
Thu, 27 May 2021 13:40:35 +0000 (15:40 +0200)
commit4b4f6cecca446abcb686c6e6c451d4f1ec1a7497
tree43e7527141c338325a6c31c2fbfcaa0e8f34e066
parent22db5e0003e1441cd829180cebb42f7a6b7a46b7
HID: magicmouse: fix NULL-deref on disconnect

Commit 9d7b18668956 ("HID: magicmouse: add support for Apple Magic
Trackpad 2") added a sanity check for an Apple trackpad but returned
success instead of -ENODEV when the check failed. This means that the
remove callback will dereference the never-initialised driver data
pointer when the driver is later unbound (e.g. on USB disconnect).

Reported-by: syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.com
Fixes: 9d7b18668956 ("HID: magicmouse: add support for Apple Magic Trackpad 2")
Cc: stable@vger.kernel.org # 4.20
Cc: Claudio Mettler <claudio@ponyfleisch.ch>
Cc: Marek Wyborski <marek.wyborski@emwesoft.com>
Cc: Sean O'Brien <seobrien@chromium.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-magicmouse.c