io-wq: check for wq exit after adding new worker task_work
authorJens Axboe <axboe@kernel.dk>
Fri, 10 Dec 2021 15:29:30 +0000 (08:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Dec 2021 08:32:51 +0000 (09:32 +0100)
commit4b4e5bbf9386d4ec21d91c0cb0fd60b9bba778ec
treeff69839225d0b947ad4b25e4c669eda116335d7d
parent024f9c7cd3d8d9cb0e499b949c7e209b47287cf2
io-wq: check for wq exit after adding new worker task_work

commit 71a85387546e50b1a37b0fa45dadcae3bfb35cf6 upstream.

We check IO_WQ_BIT_EXIT before attempting to create a new worker, and
wq exit cancels pending work if we have any. But it's possible to have
a race between the two, where creation checks exit finding it not set,
but we're in the process of exiting. The exit side will cancel pending
creation task_work, but there's a gap where we add task_work after we've
canceled existing creations at exit time.

Fix this by checking the EXIT bit post adding the creation task_work.
If it's set, run the same cancelation that exit does.

Reported-and-tested-by: syzbot+b60c982cb0efc5e05a47@syzkaller.appspotmail.com
Reviewed-by: Hao Xu <haoxu@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/io-wq.c