fs/proc: Report eip/esp in /prod/PID/stat for coredumping accepted/tizen/4.0/unified/20180111.051150 accepted/tizen/unified/20180109.172840 submit/tizen/20180109.085631 submit/tizen_4.0/20180109.085627 tizen_4.0.IoT.p2_release
authorJohn Ogness <john.ogness@linutronix.de>
Thu, 14 Sep 2017 09:42:17 +0000 (11:42 +0200)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 9 Jan 2018 08:55:32 +0000 (17:55 +0900)
commit4b21690fecf60ff9be50034083bbe6339fa98d78
treeae20746bffbe0f83eb272a5361627fa5a0b504c6
parent70e2f82e2e9d309453e6019c7e4d855a7b50d14d
fs/proc: Report eip/esp in /prod/PID/stat for coredumping

commit fd7d56270b526ca3ed0c224362e3c64a0f86687a upstream.

Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in
/proc/PID/stat") stopped reporting eip/esp because it is
racy and dangerous for executing tasks. The comment adds:

    As far as I know, there are no use programs that make any
    material use of these fields, so just get rid of them.

However, existing userspace core-dump-handler applications (for
example, minicoredumper) are using these fields since they
provide an excellent cross-platform interface to these valuable
pointers. So that commit introduced a user space visible
regression.

Partially revert the change and make the readout possible for
tasks with the proper permissions and only if the target task
has the PF_DUMPCORE flag set.

Fixes: 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in> /proc/PID/stat")
Reported-by: Marco Felsch <marco.felsch@preh.de>
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Cc: Tycho Andersen <tycho.andersen@canonical.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linux API <linux-api@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/87poatfwg6.fsf@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[l.stelmach: cherry-pick from linux-4.9.y the commit 9ad15a25669e to use eip/esp in tizen]
Signed-off-by: Ɓukasz Stelmach <l.stelmach@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I7565ddf76133081f58bcd909c44e9a596bd4e85a
fs/proc/array.c