Happy Eyeballs: Make sure that we commit the address type for SSL connections
authorJocelyn Turcotte <jocelyn.turcotte@digia.com>
Mon, 15 Oct 2012 12:35:19 +0000 (14:35 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Thu, 25 Oct 2012 14:23:49 +0000 (16:23 +0200)
commit4b1e476da085fd2f7a44113c4e2c7e6ddaa208aa
treecc1342d6670b72dbfca6163b05c2e8c0f24e307b
parentb8dd9e304157a7099fb424b464bfb33dfa526438
Happy Eyeballs: Make sure that we commit the address type for SSL connections

_q_connected checks if pendingEncrypt is false before committing the
address type. This could be used to delay the commit but nothing is done
later in _q_encrypted, so the commit is avoided completely.

This causes SSL connections on a network without IPV6 support to hang
if the domain name record contains both IPV4 and IPV6 addresses.

As SSL is handled a few layers above IP, there should be no reason to
avoid/delay committing the address type if the TCP connection was
established surccessfully. Thus this patch is removing the check completely.

Change-Id: If56a3365f9f51712b4aae3f7902711711ace86fd
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
src/network/access/qhttpnetworkconnectionchannel.cpp