phy: fix compiler array bounds warning on settings[]
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 5 Mar 2014 00:35:44 +0000 (17:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Mar 2014 21:07:25 +0000 (16:07 -0500)
commit4ae6e50c76def306d726a5d2678e88998ad5258e
treef22db725208c33c358048396af21b38e1a00e926
parente588e2f286ed7da011ed357c24c5b9a554e26595
phy: fix compiler array bounds warning on settings[]

With -Werror=array-bounds, gcc v4.7.x warns that in phy_find_valid(), the
settings[] "array subscript is above array bounds", I think because idx is
a signed integer and if the caller supplied idx < 0, we pass the guard but
still reference out of bounds.

Fix this by making idx unsigned here and elsewhere.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c