target: Fix race with SCF_SEND_DELAYED_TAS handling
authorNicholas Bellinger <nab@linux-iscsi.org>
Sun, 6 Mar 2016 01:24:28 +0000 (01:24 +0000)
committerSasha Levin <sasha.levin@oracle.com>
Sun, 6 Mar 2016 03:11:42 +0000 (22:11 -0500)
commit4aa04a257993e90d573a5dbfa4d3f3259e3f8ba1
treec9a01ba3d9799d27b9acb0e9a321023efdf4618a
parent08367c9e8f0337b0fea23acb459fb4bc40cb7be7
target: Fix race with SCF_SEND_DELAYED_TAS handling

commit 310d3d314be7f0a84011ebdc4bdccbcae9755a87 upstream.

This patch fixes a race between setting of SCF_SEND_DELAYED_TAS
in transport_send_task_abort(), and check of the same bit in
transport_check_aborted_status().

It adds a __transport_check_aborted_status() version that is
used by target_execute_cmd() when se_cmd->t_state_lock is
held, and a transport_check_aborted_status() wrapper for
all other existing callers.

Also, it handles the case where the check happens before
transport_send_task_abort() gets called.  For this, go
ahead and set SCF_SEND_DELAYED_TAS early when necessary,
and have transport_send_task_abort() send the abort.

Cc: Quinn Tran <quinn.tran@qlogic.com>
Cc: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/target/target_core_transport.c