i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable
authorColin Ian King <colin.i.king@gmail.com>
Tue, 4 Oct 2022 19:27:15 +0000 (20:27 +0100)
committerWolfram Sang <wsa@kernel.org>
Wed, 5 Oct 2022 18:52:14 +0000 (20:52 +0200)
commit4a74e79b543c115bf2b5b7a4b29db139da20b90d
tree70852f164407da6a4067fab738582e9c8bf254b0
parent2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable

The comparison of variable ret with -EPERM is always false because
ret is an u8 type. Fix this by making ret an int.

Cleans up clang warning:
drivers/i2c/busses/i2c-mchp-pci1xxxx.c:714:10: warning: result of comparison
of constant -1 with expression of type 'u8' (aka 'unsigned char') is always
false [-Wtautological-constant-out-of-range-compare]

Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-mchp-pci1xxxx.c