scsi: qedi: Check for buffer overflow in qedi_set_path()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 28 Apr 2020 13:19:39 +0000 (16:19 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 30 Apr 2020 02:12:16 +0000 (22:12 -0400)
commit4a4c0cfb4be74e216dd4446b254594707455bfc6
tree2f79bb9b72f7e4d11d5417b6fa300c25cf2162b8
parent78b874b7cbf09fbfadfa5f18a347ebef7bbb49fe
scsi: qedi: Check for buffer overflow in qedi_set_path()

Smatch complains that the "path_data->handle" variable is user controlled.
It comes from iscsi_set_path() so that seems possible.  It's harmless to
add a limit check.

The qedi->ep_tbl[] array has qedi->max_active_conns elements (which is
always ISCSI_MAX_SESS_PER_HBA (4096) elements).  The array is allocated in
the qedi_cm_alloc_mem() function.

Link: https://lore.kernel.org/r/20200428131939.GA696531@mwanda
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedi/qedi_iscsi.c