NFSv4.2: fix error handling in nfs42_proc_getxattr
authorFedor Pchelkin <pchelkin@ispras.ru>
Tue, 25 Jul 2023 11:58:58 +0000 (14:58 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2023 14:10:56 +0000 (16:10 +0200)
commit4a289d123f62f7fdf33e7ce02c4c4c0d3b708a2b
tree03a643a7e938dfa9a3834e0367cbed381e30c628
parent024f76bca9d0e29513fa99e1cd0f86bfa841743b
NFSv4.2: fix error handling in nfs42_proc_getxattr

[ Upstream commit 4e3733fd2b0f677faae21cf838a43faf317986d3 ]

There is a slight issue with error handling code inside
nfs42_proc_getxattr(). If page allocating loop fails then we free the
failing page array element which is NULL but __free_page() can't deal with
NULL args.

Found by Linux Verification Center (linuxtesting.org).

Fixes: a1f26739ccdc ("NFSv4.2: improve page handling for GETXATTR")
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/nfs42proc.c