Add and apply nullable attributes (#24679)
authorStephen Toub <stoub@microsoft.com>
Tue, 28 May 2019 10:04:13 +0000 (06:04 -0400)
committerGitHub <noreply@github.com>
Tue, 28 May 2019 10:04:13 +0000 (06:04 -0400)
commit4a1275434fff99206f2a28f5f0e87f124069eb7f
tree4e5c7667e29c969179a965048f2452f4d4bad3ad
parentbb75edbac9c40034b6683c17d86057ee9bf4192d
Add and apply nullable attributes (#24679)

* Add and apply nullable attributes

* Adapt to API review decisions

* Address PR feedback
214 files changed:
src/System.Private.CoreLib/System.Private.CoreLib.csproj
src/System.Private.CoreLib/shared/Internal/Win32/RegistryKey.cs
src/System.Private.CoreLib/shared/Interop/Unix/Interop.Errors.cs
src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.MountPoints.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.CreateFile.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.CreateFile2.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.FindFirstFileEx.cs
src/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.GetFileAttributesEx.cs
src/System.Private.CoreLib/shared/System.Private.CoreLib.Shared.projitems
src/System.Private.CoreLib/shared/System/AppContext.cs
src/System.Private.CoreLib/shared/System/AppDomain.cs
src/System.Private.CoreLib/shared/System/Array.cs
src/System.Private.CoreLib/shared/System/ArraySegment.cs
src/System.Private.CoreLib/shared/System/BitConverter.cs
src/System.Private.CoreLib/shared/System/CharEnumerator.cs
src/System.Private.CoreLib/shared/System/Collections/ArrayList.cs
src/System.Private.CoreLib/shared/System/Collections/Concurrent/ConcurrentQueue.cs
src/System.Private.CoreLib/shared/System/Collections/Concurrent/ConcurrentQueueSegment.cs
src/System.Private.CoreLib/shared/System/Collections/Concurrent/IProducerConsumerCollection.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/ArraySortHelper.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/Comparer.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/Dictionary.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/EqualityComparer.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/IComparer.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/IDictionary.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/IEqualityComparer.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/IReadOnlyDictionary.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/List.cs
src/System.Private.CoreLib/shared/System/Collections/Generic/NonRandomizedStringEqualityComparer.cs
src/System.Private.CoreLib/shared/System/Collections/HashHelpers.SerializationInfoTable.cs
src/System.Private.CoreLib/shared/System/Collections/IDictionary.cs
src/System.Private.CoreLib/shared/System/Collections/ListDictionaryInternal.cs
src/System.Private.CoreLib/shared/System/Collections/ObjectModel/Collection.cs
src/System.Private.CoreLib/shared/System/Collections/ObjectModel/ReadOnlyCollection.cs
src/System.Private.CoreLib/shared/System/Convert.cs
src/System.Private.CoreLib/shared/System/DateTimeOffset.cs
src/System.Private.CoreLib/shared/System/DefaultBinder.cs
src/System.Private.CoreLib/shared/System/Delegate.cs
src/System.Private.CoreLib/shared/System/Diagnostics/CodeAnalysis/NullableAttributes.cs [new file with mode: 0644]
src/System.Private.CoreLib/shared/System/Diagnostics/Contracts/Contracts.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Debug.cs
src/System.Private.CoreLib/shared/System/Diagnostics/DebugProvider.cs
src/System.Private.CoreLib/shared/System/Diagnostics/StackTrace.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/DiagnosticCounter.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventProvider.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/ConcurrentSet.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/EventPayload.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/PropertyValue.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/Statics.cs
src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/TypeAnalysis.cs
src/System.Private.CoreLib/shared/System/Enum.cs
src/System.Private.CoreLib/shared/System/Environment.Unix.cs
src/System.Private.CoreLib/shared/System/Environment.Win32.cs
src/System.Private.CoreLib/shared/System/Environment.cs
src/System.Private.CoreLib/shared/System/Globalization/CalendarData.Unix.cs
src/System.Private.CoreLib/shared/System/Globalization/CalendarData.Windows.cs
src/System.Private.CoreLib/shared/System/Globalization/CalendarData.cs
src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.cs
src/System.Private.CoreLib/shared/System/Globalization/CultureData.Windows.cs
src/System.Private.CoreLib/shared/System/Globalization/CultureData.cs
src/System.Private.CoreLib/shared/System/Globalization/DateTimeParse.cs
src/System.Private.CoreLib/shared/System/Globalization/IdnMapping.Windows.cs
src/System.Private.CoreLib/shared/System/Globalization/JapaneseCalendar.Win32.cs
src/System.Private.CoreLib/shared/System/Globalization/JapaneseLunisolarCalendar.cs
src/System.Private.CoreLib/shared/System/Globalization/SortVersion.cs
src/System.Private.CoreLib/shared/System/Globalization/TextElementEnumerator.cs
src/System.Private.CoreLib/shared/System/Globalization/TimeSpanParse.cs
src/System.Private.CoreLib/shared/System/IComparable.cs
src/System.Private.CoreLib/shared/System/IEquatable.cs
src/System.Private.CoreLib/shared/System/IO/FileStream.Unix.cs
src/System.Private.CoreLib/shared/System/IO/FileStream.Windows.cs
src/System.Private.CoreLib/shared/System/IO/MemoryStream.cs
src/System.Private.CoreLib/shared/System/IO/Path.cs
src/System.Private.CoreLib/shared/System/IO/PathInternal.Windows.cs
src/System.Private.CoreLib/shared/System/IO/Stream.cs
src/System.Private.CoreLib/shared/System/IO/StreamReader.cs
src/System.Private.CoreLib/shared/System/IO/StreamWriter.cs
src/System.Private.CoreLib/shared/System/IO/TextReader.cs
src/System.Private.CoreLib/shared/System/IO/TextWriter.cs
src/System.Private.CoreLib/shared/System/IO/UnmanagedMemoryStream.cs
src/System.Private.CoreLib/shared/System/Lazy.cs
src/System.Private.CoreLib/shared/System/Math.cs
src/System.Private.CoreLib/shared/System/Memory.cs
src/System.Private.CoreLib/shared/System/MemoryExtensions.Fast.cs
src/System.Private.CoreLib/shared/System/Number.Parsing.cs
src/System.Private.CoreLib/shared/System/Numerics/Vector.cs
src/System.Private.CoreLib/shared/System/Numerics/Vector.tt
src/System.Private.CoreLib/shared/System/Reflection/SignatureType.cs
src/System.Private.CoreLib/shared/System/Resources/FastResourceComparer.cs
src/System.Private.CoreLib/shared/System/Resources/ResourceManager.cs
src/System.Private.CoreLib/shared/System/Resources/ResourceReader.Core.cs
src/System.Private.CoreLib/shared/System/Resources/ResourceReader.cs
src/System.Private.CoreLib/shared/System/Resources/ResourceSet.cs
src/System.Private.CoreLib/shared/System/Resources/RuntimeResourceSet.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AsyncMethodBuilder.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ConditionalWeakTable.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DateTimeConstantAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ICastable.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeHelpers.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/StrongBox.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/YieldAwaitable.cs
src/System.Private.CoreLib/shared/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/Marshal.NoCom.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/Marshal.Unix.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/Marshal.Windows.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/Marshal.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/MemoryMarshal.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/NativeLibrary.cs
src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/SerializationInfo.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/SerializationInfoEnumerator.cs
src/System.Private.CoreLib/shared/System/Span.Fast.cs
src/System.Private.CoreLib/shared/System/SpanHelpers.T.cs
src/System.Private.CoreLib/shared/System/String.Comparison.cs
src/System.Private.CoreLib/shared/System/String.Searching.cs
src/System.Private.CoreLib/shared/System/String.cs
src/System.Private.CoreLib/shared/System/StringComparer.cs
src/System.Private.CoreLib/shared/System/Text/DecoderBestFitFallback.cs
src/System.Private.CoreLib/shared/System/Text/DecoderExceptionFallback.cs
src/System.Private.CoreLib/shared/System/Text/DecoderFallback.cs
src/System.Private.CoreLib/shared/System/Text/DecoderNLS.cs
src/System.Private.CoreLib/shared/System/Text/DecoderReplacementFallback.cs
src/System.Private.CoreLib/shared/System/Text/EncoderBestFitFallback.cs
src/System.Private.CoreLib/shared/System/Text/EncoderFallback.cs
src/System.Private.CoreLib/shared/System/Text/EncoderReplacementFallback.cs
src/System.Private.CoreLib/shared/System/Text/Encoding.cs
src/System.Private.CoreLib/shared/System/Text/EncodingData.cs
src/System.Private.CoreLib/shared/System/Text/EncodingTable.cs
src/System.Private.CoreLib/shared/System/Text/StringBuilder.cs
src/System.Private.CoreLib/shared/System/Text/StringRuneEnumerator.cs
src/System.Private.CoreLib/shared/System/Text/UTF32Encoding.cs
src/System.Private.CoreLib/shared/System/Text/UTF8Encoding.cs
src/System.Private.CoreLib/shared/System/Text/Unicode/Utf8Utility.cs
src/System.Private.CoreLib/shared/System/Text/UnicodeEncoding.cs
src/System.Private.CoreLib/shared/System/Text/ValueStringBuilder.cs
src/System.Private.CoreLib/shared/System/Threading/AsyncLocal.cs
src/System.Private.CoreLib/shared/System/Threading/CancellationToken.cs
src/System.Private.CoreLib/shared/System/Threading/CancellationTokenSource.cs
src/System.Private.CoreLib/shared/System/Threading/EventWaitHandle.Windows.cs
src/System.Private.CoreLib/shared/System/Threading/EventWaitHandle.cs
src/System.Private.CoreLib/shared/System/Threading/ExecutionContext.cs
src/System.Private.CoreLib/shared/System/Threading/LazyInitializer.cs
src/System.Private.CoreLib/shared/System/Threading/Mutex.Windows.cs
src/System.Private.CoreLib/shared/System/Threading/Mutex.cs
src/System.Private.CoreLib/shared/System/Threading/ReaderWriterLockSlim.cs
src/System.Private.CoreLib/shared/System/Threading/Semaphore.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/ConcurrentExclusiveSchedulerPair.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/Future.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/FutureFactory.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/ProducerConsumerQueues.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/Sources/IValueTaskSource.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/Sources/ManualResetValueTaskSourceCore.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/Task.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskCompletionSource.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskFactory.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/TaskScheduler.cs
src/System.Private.CoreLib/shared/System/Threading/Tasks/ValueTask.cs
src/System.Private.CoreLib/shared/System/Threading/Thread.cs
src/System.Private.CoreLib/shared/System/Threading/ThreadLocal.cs
src/System.Private.CoreLib/shared/System/Threading/Timer.cs
src/System.Private.CoreLib/shared/System/Threading/Volatile.cs
src/System.Private.CoreLib/shared/System/Threading/WaitHandle.cs
src/System.Private.CoreLib/shared/System/ThrowHelper.cs
src/System.Private.CoreLib/shared/System/TimeZone.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.AdjustmentRule.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.Unix.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.Win32.cs
src/System.Private.CoreLib/shared/System/TimeZoneInfo.cs
src/System.Private.CoreLib/shared/System/Tuple.cs
src/System.Private.CoreLib/shared/System/Type.Helpers.cs
src/System.Private.CoreLib/shared/System/ValueTuple.cs
src/System.Private.CoreLib/shared/System/Version.cs
src/System.Private.CoreLib/shared/System/WinRTFolderPaths.cs
src/System.Private.CoreLib/src/System/Array.CoreCLR.cs
src/System.Private.CoreLib/src/System/Attribute.CoreCLR.cs
src/System.Private.CoreLib/src/System/Collections/Generic/EqualityComparer.CoreCLR.cs
src/System.Private.CoreLib/src/System/Collections/ObjectModel/ReadOnlyDictionary.cs
src/System.Private.CoreLib/src/System/Diagnostics/Eventing/XplatEventLogger.cs
src/System.Private.CoreLib/src/System/Environment.CoreCLR.cs
src/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs
src/System.Private.CoreLib/src/System/MulticastDelegate.cs
src/System.Private.CoreLib/src/System/Reflection/Assembly.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/ILGenerator.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/ISymWrapperCore.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/MethodBuilder.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
src/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
src/System.Private.CoreLib/src/System/RtType.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/ICastableHelpers.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/jithelpers.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/ComEventsMethod.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/CustomMarshalers/EnumeratorViewOfEnumVariant.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/CLRIReferenceImpl.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/ConstantSplittableMap.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/EventRegistrationTokenTable.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/IMapViewToIReadOnlyDictionaryAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/IteratorToEnumeratorAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/MapToDictionaryAdapter.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/WindowsRuntimeMarshal.cs
src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyDependencyResolver.cs
src/System.Private.CoreLib/src/System/StubHelpers.cs
src/System.Private.CoreLib/src/System/Threading/Interlocked.cs
src/System.Private.CoreLib/src/System/Threading/Monitor.cs
src/System.Private.CoreLib/src/System/Threading/ThreadPool.CoreCLR.cs
src/System.Private.CoreLib/src/System/Utf8String.Construction.cs
src/System.Private.CoreLib/src/System/Utf8String.cs
src/System.Private.CoreLib/src/System/WeakReferenceOfT.cs