netfilter: tproxy: fix deadlock due to missing BH disable
authorFlorian Westphal <fw@strlen.de>
Fri, 3 Mar 2023 09:58:56 +0000 (10:58 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 6 Mar 2023 11:09:48 +0000 (12:09 +0100)
commit4a02426787bf024dafdb79b362285ee325de3f5e
tree88f0905ed0e7028251bdbda88b015e84d1b46ed6
parent9f7dd42f0db1dc6915a52d4a8a96ca18dd8cc34e
netfilter: tproxy: fix deadlock due to missing BH disable

The xtables packet traverser performs an unconditional local_bh_disable(),
but the nf_tables evaluation loop does not.

Functions that are called from either xtables or nftables must assume
that they can be called in process context.

inet_twsk_deschedule_put() assumes that no softirq interrupt can occur.
If tproxy is used from nf_tables its possible that we'll deadlock
trying to aquire a lock already held in process context.

Add a small helper that takes care of this and use it.

Link: https://lore.kernel.org/netfilter-devel/401bd6ed-314a-a196-1cdc-e13c720cc8f2@balasys.hu/
Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support")
Reported-and-tested-by: Major Dávid <major.david@balasys.hu>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/nf_tproxy.h
net/ipv4/netfilter/nf_tproxy_ipv4.c
net/ipv6/netfilter/nf_tproxy_ipv6.c