gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd
authorAndrew Price <anprice@redhat.com>
Mon, 8 Oct 2018 12:52:43 +0000 (07:52 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 1 Dec 2018 08:42:51 +0000 (09:42 +0100)
commit49ee6220be1b9c2dfd00a4a7adc55c2d7ffc7faf
tree71080d31c2a5ebb7313496fa0f2fd17b8ade657f
parent8376fdc999be008f0e9918db52f1ed8c08f5a1c9
gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd

commit 4c62bd9cea7bcf10292f7e4c57a2bca332942697 upstream.

When alloc_percpu() fails, sdp gets freed but sb->s_fs_info still points
to the same address. Move the assignment after that error check so that
s_fs_info can only point to a valid sdp or NULL, which is checked for
later in the error path, in gfs2_kill_super().

Reported-by: syzbot+dcb8b3587445007f5808@syzkaller.appspotmail.com
Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/gfs2/ops_fstype.c