uic: use QStringLiteral() instead of QString::fromUtf8() where applicable
authorMarc Mutz <marc.mutz@kdab.com>
Sun, 11 Dec 2011 15:55:01 +0000 (16:55 +0100)
committerQt by Nokia <qt-info@nokia.com>
Mon, 20 Feb 2012 14:17:08 +0000 (15:17 +0100)
commit49b08f96e824f49fab9aa5c9a1a0ed582d4558bb
treeb9e1df0b1a332a78ce1ef9cf0d90265098c9e414
parentac1689245419a6fd44e3250d2fdf3d3a058a0c17
uic: use QStringLiteral() instead of QString::fromUtf8() where applicable

Many (most?) strings written aren't in fact UTF-8, and we can check at
compile-time which are and which aren't, so don't hard-code fromUtf8()
but use the much more efficient QStringLiteral() where applicable.

This is low-hanging fruit. This patch only optimises US-ASCII string
literals, not those that are latin-1 or even UTF-8, because that would
require more extensive changes to the original fixString() function.

Likewise, there are also other calls to QString::fromUtf8() being
generated (e.g. in the pixmap code) that could benefit from being
turned into QStringLiterals, but their code paths are more involved
than those this patch fixes.

This patch at least suffices in turning all the setObjectName()
arguments into QStringLiterals, which was the main goal.

The autotest baseline has been updated with the new expected results.

Change-Id: Ic1ef67f500f9ff92d36164d515f4e004ef2a10bc
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
101 files changed:
src/tools/uic/cpp/cppwriteinitialization.cpp
src/tools/uic/utils.h
tests/auto/tools/uic/baseline/Dialog_with_Buttons_Bottom.ui.h
tests/auto/tools/uic/baseline/Dialog_with_Buttons_Right.ui.h
tests/auto/tools/uic/baseline/Dialog_without_Buttons.ui.h
tests/auto/tools/uic/baseline/Main_Window.ui.h
tests/auto/tools/uic/baseline/Widget.ui.h
tests/auto/tools/uic/baseline/addlinkdialog.ui.h
tests/auto/tools/uic/baseline/addtorrentform.ui.h
tests/auto/tools/uic/baseline/authenticationdialog.ui.h
tests/auto/tools/uic/baseline/backside.ui.h
tests/auto/tools/uic/baseline/batchtranslation.ui.h
tests/auto/tools/uic/baseline/bookmarkdialog.ui.h
tests/auto/tools/uic/baseline/bookwindow.ui.h
tests/auto/tools/uic/baseline/browserwidget.ui.h
tests/auto/tools/uic/baseline/calculator.ui.h
tests/auto/tools/uic/baseline/calculatorform.ui.h
tests/auto/tools/uic/baseline/certificateinfo.ui.h
tests/auto/tools/uic/baseline/chatdialog.ui.h
tests/auto/tools/uic/baseline/chatmainwindow.ui.h
tests/auto/tools/uic/baseline/chatsetnickname.ui.h
tests/auto/tools/uic/baseline/config.ui.h
tests/auto/tools/uic/baseline/connectdialog.ui.h
tests/auto/tools/uic/baseline/controller.ui.h
tests/auto/tools/uic/baseline/cookies.ui.h
tests/auto/tools/uic/baseline/cookiesexceptions.ui.h
tests/auto/tools/uic/baseline/default.ui.h
tests/auto/tools/uic/baseline/dialog.ui.h
tests/auto/tools/uic/baseline/downloaditem.ui.h
tests/auto/tools/uic/baseline/downloads.ui.h
tests/auto/tools/uic/baseline/embeddeddialog.ui.h
tests/auto/tools/uic/baseline/filespage.ui.h
tests/auto/tools/uic/baseline/filternamedialog.ui.h
tests/auto/tools/uic/baseline/filterpage.ui.h
tests/auto/tools/uic/baseline/finddialog.ui.h
tests/auto/tools/uic/baseline/form.ui.h
tests/auto/tools/uic/baseline/formwindowsettings.ui.h
tests/auto/tools/uic/baseline/generalpage.ui.h
tests/auto/tools/uic/baseline/gridalignment.ui.h
tests/auto/tools/uic/baseline/gridpanel.ui.h
tests/auto/tools/uic/baseline/helpdialog.ui.h
tests/auto/tools/uic/baseline/history.ui.h
tests/auto/tools/uic/baseline/icontheme.ui.h
tests/auto/tools/uic/baseline/identifierpage.ui.h
tests/auto/tools/uic/baseline/imagedialog.ui.h
tests/auto/tools/uic/baseline/inputpage.ui.h
tests/auto/tools/uic/baseline/installdialog.ui.h
tests/auto/tools/uic/baseline/languagesdialog.ui.h
tests/auto/tools/uic/baseline/listwidgeteditor.ui.h
tests/auto/tools/uic/baseline/mainwindow.ui.h
tests/auto/tools/uic/baseline/mydialog.ui.h
tests/auto/tools/uic/baseline/myform.ui.h
tests/auto/tools/uic/baseline/newactiondialog.ui.h
tests/auto/tools/uic/baseline/newdynamicpropertydialog.ui.h
tests/auto/tools/uic/baseline/newform.ui.h
tests/auto/tools/uic/baseline/orderdialog.ui.h
tests/auto/tools/uic/baseline/outputpage.ui.h
tests/auto/tools/uic/baseline/pagefold.ui.h
tests/auto/tools/uic/baseline/paletteeditor.ui.h
tests/auto/tools/uic/baseline/passworddialog.ui.h
tests/auto/tools/uic/baseline/pathpage.ui.h
tests/auto/tools/uic/baseline/phrasebookbox.ui.h
tests/auto/tools/uic/baseline/plugindialog.ui.h
tests/auto/tools/uic/baseline/preferencesdialog.ui.h
tests/auto/tools/uic/baseline/previewconfigurationwidget.ui.h
tests/auto/tools/uic/baseline/previewdialogbase.ui.h
tests/auto/tools/uic/baseline/previewwidget.ui.h
tests/auto/tools/uic/baseline/proxy.ui.h
tests/auto/tools/uic/baseline/qfiledialog.ui.h
tests/auto/tools/uic/baseline/qpagesetupwidget.ui.h
tests/auto/tools/uic/baseline/qprintpropertieswidget.ui.h
tests/auto/tools/uic/baseline/qprintsettingsoutput.ui.h
tests/auto/tools/uic/baseline/qprintwidget.ui.h
tests/auto/tools/uic/baseline/qsqlconnectiondialog.ui.h
tests/auto/tools/uic/baseline/qtgradientdialog.ui.h
tests/auto/tools/uic/baseline/qtgradienteditor.ui.h
tests/auto/tools/uic/baseline/qtgradientview.ui.h
tests/auto/tools/uic/baseline/qtgradientviewdialog.ui.h
tests/auto/tools/uic/baseline/qtresourceeditordialog.ui.h
tests/auto/tools/uic/baseline/qttoolbardialog.ui.h
tests/auto/tools/uic/baseline/querywidget.ui.h
tests/auto/tools/uic/baseline/remotecontrol.ui.h
tests/auto/tools/uic/baseline/saveformastemplate.ui.h
tests/auto/tools/uic/baseline/settings.ui.h
tests/auto/tools/uic/baseline/signalslotdialog.ui.h
tests/auto/tools/uic/baseline/sslclient.ui.h
tests/auto/tools/uic/baseline/sslerrors.ui.h
tests/auto/tools/uic/baseline/statistics.ui.h
tests/auto/tools/uic/baseline/stringlisteditor.ui.h
tests/auto/tools/uic/baseline/stylesheeteditor.ui.h
tests/auto/tools/uic/baseline/tabbedbrowser.ui.h
tests/auto/tools/uic/baseline/tablewidgeteditor.ui.h
tests/auto/tools/uic/baseline/tetrixwindow.ui.h
tests/auto/tools/uic/baseline/textfinder.ui.h
tests/auto/tools/uic/baseline/topicchooser.ui.h
tests/auto/tools/uic/baseline/translatedialog.ui.h
tests/auto/tools/uic/baseline/translationsettings.ui.h
tests/auto/tools/uic/baseline/treewidgeteditor.ui.h
tests/auto/tools/uic/baseline/trpreviewtool.ui.h
tests/auto/tools/uic/baseline/validators.ui.h
tests/auto/tools/uic/baseline/wateringconfigdialog.ui.h