uml: flush stdout before forking
authorVegard Nossum <vegard.nossum@oracle.com>
Fri, 18 Dec 2015 20:28:53 +0000 (21:28 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 3 Feb 2016 19:01:45 +0000 (14:01 -0500)
commit498b346868790663ef443951bb06a30a57b64b32
treeb7f221bddb839ffc51a49fbc0aa7f752416c4980
parent4e623240d3054ca29fbb294d15a24b2ed971a413
uml: flush stdout before forking

[ Upstream commit 0754fb298f2f2719f0393491d010d46cfb25d043 ]

I was seeing some really weird behaviour where piping UML's output
somewhere would cause output to get duplicated:

  $ ./vmlinux | head -n 40
  Checking that ptrace can change system call numbers...Core dump limits :
          soft - 0
          hard - NONE
  OK
  Checking syscall emulation patch for ptrace...Core dump limits :
          soft - 0
          hard - NONE
  OK
  Checking advanced syscall emulation patch for ptrace...Core dump limits :
          soft - 0
          hard - NONE
  OK
  Core dump limits :
          soft - 0
          hard - NONE

This is because these tests do a fork() which duplicates the non-empty
stdout buffer, then glibc flushes the duplicated buffer as each child
exits.

A simple workaround is to flush before forking.

Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
arch/um/os-Linux/start_up.c